feat: replace hash routing with BrowserRouter - #478
Open
LWilkin wants to merge 1 commit into
Open
Conversation
- Swap HashRouter for BrowserRouter - Remove hash rewrite script from index.html - Add SPA fallback: 404.html encoder plus index.html decoder - Add shim to rescue legacy /#/ links already in circulation - Remove preventDefault from markdown-link so anchors are shareable - Correct og:url to www hostname, remove duplicate empty og:title - Add per-route canonical tags in usePageTitle - Strip hash URLs from 93 criteria markdown files - Fix createMarkdown.sh template so new content stays clean - Add local routing test tools: serve-pages.js, check-routes.js Verified locally: build compiles, 217/217 routes pass, 15 test suites pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verified locally: build compiles, 217/217 routes pass, 15 test suites pass.